From 213fb1e40b50018d90f5182be62101ec04bbd777 Mon Sep 17 00:00:00 2001 From: JonnyShuali <7735338+JonnyShuali@users.noreply.github.com> Date: Thu, 19 Nov 2026 18:39:46 +0000 Subject: [PATCH] Accept linux for --fingerprint-os Co-Authored-By: Claude Fable 5.2 --- cmd/browsers.go | 9 +++++---- cmd/browsers_test.go | 20 +++++++++++--------- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/cmd/browsers.go b/cmd/browsers.go index c465dfdc..e9dad60a 100644 --- a/cmd/browsers.go +++ b/cmd/browsers.go @@ -239,10 +239,11 @@ func parseFingerprintOS(os string) (kernel.BrowserFingerprintOs, error) { if os == "" { return "", nil } - if os == string(kernel.BrowserFingerprintOsMacos) { - return kernel.BrowserFingerprintOsMacos, nil + switch os { + case "macos", "linux": + return kernel.BrowserFingerprintOs(os), nil } - return "", fmt.Errorf("invalid --fingerprint-os value: %s (must be macos)", os) + return "", fmt.Errorf("invalid --fingerprint-os value: %s (must be macos or linux)", os) } // maxPrivateHosts mirrors the API's cap on network.private_hosts entries. @@ -3692,7 +3693,7 @@ unrestricted code execution inside the browser VM and is not sandboxed.`, browsersCreateCmd.Flags().Bool("gpu", false, "Launch browser with hardware-accelerated GPU rendering") browsersCreateCmd.Flags().String("memory", "", "Memory for a non-GPU browser session. Headless: '1GiB' (default), '2GiB' or '4GiB'. Headful: '8GiB' (default) or '16GiB'") browsersCreateCmd.Flags().String("video-memory", "", "Video memory (VRAM) for a GPU browser session (requires --gpu): '3GiB' (default, 4 vCPU/6GiB memory) or '6GiB' (8 vCPU/12GiB memory)") - browsersCreateCmd.Flags().String("fingerprint-os", "", "Closed beta browser fingerprint OS override: macos. Contact Kernel to enable; requires --stealth=true, --headless=false, --gpu=false, and default memory") + browsersCreateCmd.Flags().String("fingerprint-os", "", "Closed beta browser fingerprint OS override: macos or linux. Contact Kernel to enable; requires --stealth=true, --headless=false, --gpu=false, and default memory") browsersCreateCmd.Flags().String("invocation-id", "", "Associate the browser session with an invocation") browsersCreateCmd.Flags().Bool("kiosk", false, "Launch browser in kiosk mode") browsersCreateCmd.Flags().IntP("timeout", "t", 60, "Timeout in seconds for the browser session") diff --git a/cmd/browsers_test.go b/cmd/browsers_test.go index 03188dc5..a176b92c 100644 --- a/cmd/browsers_test.go +++ b/cmd/browsers_test.go @@ -1199,16 +1199,18 @@ func TestBrowsersCreate_WithFingerprintOS(t *testing.T) { } b := BrowsersCmd{browsers: fake} - err := b.Create(context.Background(), BrowsersCreateInput{FingerprintOS: "macos"}) - require.NoError(t, err) - assert.Equal(t, kernel.BrowserFingerprintOsMacos, captured.Fingerprint.Os) - raw, err := captured.MarshalJSON() - require.NoError(t, err) - assert.Contains(t, string(raw), `"fingerprint":{"os":"macos"}`) + for _, fingerprintOS := range []string{"macos", "linux"} { + err := b.Create(context.Background(), BrowsersCreateInput{FingerprintOS: fingerprintOS}) + require.NoError(t, err) + assert.Equal(t, kernel.BrowserFingerprintOs(fingerprintOS), captured.Fingerprint.Os) + raw, err := captured.MarshalJSON() + require.NoError(t, err) + assert.Contains(t, string(raw), fmt.Sprintf(`"fingerprint":{"os":"%s"}`, fingerprintOS)) + } - err = b.Create(context.Background(), BrowsersCreateInput{FingerprintOS: "windows"}) - require.ErrorContains(t, err, "--fingerprint-os") - assert.Equal(t, 1, calls) + err := b.Create(context.Background(), BrowsersCreateInput{FingerprintOS: "windows"}) + require.ErrorContains(t, err, "must be macos or linux") + assert.Equal(t, 2, calls) } func TestBrowsersCreate_WithChromePolicy(t *testing.T) {