Skip to content

Fix perfect_cube for cubes above 27 and for negative numbers - #15778

Open
JayPokale wants to merge 1 commit into
TheAlgorithms:masterfrom
JayPokale:fix-perfect-cube-float-root
Open

JayPokale wants to merge 1 commit into
TheAlgorithms:masterfrom
JayPokale:fix-perfect-cube-float-root

Conversation

@JayPokale

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

maths/perfect_cube.py::perfect_cube cubed the float cube root and compared it with n. That is not exact: 64 ** (1 / 3) is 3.9999999999999996, so almost every cube was reported as not a cube. Of i**3 for i in 0..199, 196 returned False (only 0, 1, 2 and 3 passed); the only doctest was 27. A negative n went through a complex root: perfect_cube(-64) was False and perfect_cube(-24) was True.

The cube root of abs(n) is now rounded to an integer and its cube is compared with abs(n), so negative cubes count as cubes, like in perfect_cube_binary_search in the same file. I added doctests for the cases above (they fail on master); the added doctests are the regression evidence for this one function, so I kept them in the same PR.

I checked -3000..3000 against an exact integer search and k**3 / k**3 + 1 for k up to 10^5: no mismatches. ruff check, ruff format --check and python -m doctest pass.

Written with the help of Claude Code (Claude Sonnet 5.5).

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

perfect_cube cubed the float cube root, which is not exact: 64 ** (1 / 3) is
3.9999999999999996, so almost every cube (4**3, 5**3, ...) was reported as
not a cube, and a negative number went through a complex root, so -64 was
False while -24 was True. Round the cube root of abs(n) to an integer and
compare its cube with abs(n).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants