Skip to content

Fix fast_primes(2) returning no primes - #15779

Open
JayPokale wants to merge 1 commit into
TheAlgorithms:masterfrom
JayPokale:fix-fast-primes-two
Open

JayPokale wants to merge 1 commit into
TheAlgorithms:masterfrom
JayPokale:fix-fast-primes-two

Conversation

@JayPokale

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

maths/prime_numbers.py::fast_primes yielded 2 only when max_n > 2, so list(fast_primes(2)) was [] while slow_primes(2) and primes(2) return [2]. The condition is now max_n >= 2. The existing doctests only used values above 2; I added 1, 2 and 3 (the 2 case fails on master).

I compared fast_primes(n) with slow_primes(n) and primes(n) for n in -3..299: they agree. ruff check, ruff format --check and python -m doctest pass.

Written with the help of Claude Code (Claude Sonnet 5.5).

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

fast_primes yielded 2 only for max_n > 2, so fast_primes(2) was empty while
slow_primes(2) and primes(2) return [2]. Yield it for max_n >= 2.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant