Repository navigation
Conversation
The REST spec defines a 404 from createView, registerTable and registerView as "the namespace specified does not exist", and create_table already maps it to NoSuchNamespaceError. These three methods had no 404 mapping, so a missing namespace surfaced as a generic RESTError.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The REST OpenAPI spec defines a 404 from
createView,registerTableandregisterViewas "Not Found - The namespace specified does not exist".create_tablealready maps that toNoSuchNamespaceError. However,create_view,register_tableandregister_viewonly mapped 409, so a missing namespace surfaced as a genericRESTError.Are these changes tested?
Yes. Added
test_create_view_404,test_register_table_404andtest_register_view_404intests/catalog/test_rest.py.Are there any user-facing changes?
Yes. These methods now raise
NoSuchNamespaceErrorinstead ofRESTErrorwhen the namespace does not exist.AI disclosure: an AI coding assistant helped draft the change and the tests. The mapping was checked against the REST OpenAPI spec, and the catalog tests and linters were run before submitting.