Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4467
Rationale for this change
_cast_if_neededrelabels a UTC alias (+00:00,Etc/UTC,Z) toUTCfortimestamptzcolumns but not for
timestamptz_ns. A table whose files come from writers that label UTCdifferently, or where some files predate the column, then fails in
pa.concat_tables. This addsthe same handling for
TimestamptzNanoType, for nanosecond values only: no unit conversion, so avalue is never widened or truncated.
Are these changes tested?
Yes.
test__to_requested_schema_timestamptz_ns_utc_alias_concatenatesprojects a file without thecolumn and a file with a
+00:00-labelledtimestamp[ns]column, checks the label isUTC, andconcatenates them; nanosecond digits are kept. It fails on main and passes with the change.
Are there any user-facing changes?
Scans of such tables succeed instead of raising
ArrowTypeError. No API change.