Repository navigation
Leave intermediate snapshots out of the snapshot log - #4470
Open
ShivamSharma43 wants to merge 1 commit into
Open
ShivamSharma43 wants to merge 1 commit into
ShivamSharma43 wants to merge 1 commit into
Conversation
A commit that sets main more than once, such as an overwrite, added every snapshot to the snapshot log, so time travel could resolve to a snapshot that was never the committed state of the table. Keep only the last one, like Java does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A commit that sets
mainmore than once adds every one of those snapshots to the snapshot log.Table.overwritedoes this when it commits a delete and an append together, so time travel can resolve to the delete snapshot, which was never the committed state of the table:This happens in catalogs where PyIceberg applies the updates itself. Java's
TableMetadata.Buildersuppresses these entries (intermediateSnapshotIdSetandupdateSnapshotLog). This change does the same: snapshots that are added and set asmain, but are not current once all updates are applied, are removed from the log. They stay insnapshots.Are these changes tested?
Yes, with a unit test on
update_table_metadataand a test that overwrites a table in the memory and SQL catalogs. Both fail without the fix.Are there any user-facing changes?
Yes.
Table.history()andinspect.history()have one entry for a commit that replaces its own snapshots, andsnapshot_as_of_timestampno longer returns the replaced ones. Tables that already have such entries in their log are not rewritten.