Repository navigation
Conversation
setupReadTimeout and setupWriteTimeout made a new context.AfterFunc callback for each frame, so each frame read or write with a cancelable context allocated it. The callbacks do not depend on the frame, so each one is made on first use and reused under readMu or writeFrameMu.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setupReadTimeoutandsetupWriteTimeoutmade a newcontext.AfterFunccallback for each frame. Now the code makes each callback once, on first use.readMuandwriteFrameMuguard them. The behavior does not change.BenchmarkConn/disabledCompressBenchmarkConn/compressContextTakeoverI measured no slowdown on AMD EPYC 7763 (Go 1.27.4, 24 interleaved rounds, 3 code layouts). Each
Connis 32 bytes larger.I did not make the callbacks in
newConn, because that madenewConn6% to 14% slower.Checks:
go test -race,go vetandstaticcheckpass, also for WASM.