Repository navigation
Add opt-in status-code retries to Client and AsyncClient - #3857
Open
masterramankhatri-glitch wants to merge 4 commits into
Open
masterramankhatri-glitch wants to merge 4 commits into
masterramankhatri-glitch wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds opt-in status-code retries to httpx. Until now, httpx did not
retry a request when the server responded with a transient error status
(for example 429 or 503), so every user had to write their own retry loop
around the client. This change adds that capability inside the client
itself, in a fully opt-in way.
What changed
ClientandAsyncClientcan now be configured to automatically retrya request when the response has one of the configured retryable status
codes.
opt in behaves exactly as before, so this is fully backward compatible.
is received or the configured attempts are exhausted.
httpx/_client.py.docs/advanced/clients.md.Tests
tests/client/test_retries.pycovering theretry behaviour for both the sync and async clients — 21 tests, all
passing.
pre-existing and unrelated to this change).
Notes
This is intentionally a minimal, focused implementation: only status-code
based retries, no changes to transport-level or connection-error handling,
so it is easy to review and safe to extend later.