Repository navigation
Guards: Update Guards-CFG integration to recognize MatchSuccessors. - #23182
Draft
aschackmull wants to merge 2 commits into
Draft
aschackmull wants to merge 2 commits into
aschackmull wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements the way that switch-case guards work in the shared Guards library. Given the now much more uniform handling of switch statements and patterns in the shared CFG, we can depend on MatchingSuccessors to more precisely indicate matching patterns. When these patterns occur in a switch-case context then we can have them satisfy
isEquality, which then provides the relevant implications. Support for expression-less switch statements is also added (they're considered to switch on the implicit constanttrue).A legacy hook is kept in order to not drop support for C++ switch-case guards.