Skip to content

Accept linux for --fingerprint-os - #323

Closed
JonnyShuali wants to merge 1 commit into
mainfrom
hypeship/fingerprint-os-linux
Closed

JonnyShuali wants to merge 1 commit into
mainfrom
hypeship/fingerprint-os-linux

Conversation

@JonnyShuali

@JonnyShuali JonnyShuali commented Nov 19, 2026 •

Copy link
Copy Markdown

Summary

kernel browsers create --fingerprint-os only accepted macos and rejected linux client-side. The API accepts both values for organizations with the closed beta enabled, so the CLI now does too.

  • parseFingerprintOS accepts macos and linux; the error message lists both.
  • The flag help text lists both values. The closed-beta wording and the other requirements are unchanged.
  • No SDK bump: the pinned Go SDK has no linux constant for BrowserFingerprintOs, but the type is a string, so the validated value is converted directly.

Testing

  • go build ./..., go vet ./..., go test ./... pass.
  • TestBrowsersCreate_WithFingerprintOS now covers both accepted values and asserts the rejection message.
  • Verified against a test environment: kernel browsers create --stealth --fingerprint-os linux -o json returns "fingerprint":{"os":"linux"}, and an unsupported value fails with Invalid --fingerprint-os value: windows (must be macos or linux).

🤖 Generated with Claude Code


Note

Low Risk
Small CLI validation and test updates for an existing closed-beta flag; no auth or infrastructure changes.

Overview
The CLI now treats linux as a valid value for kernel browsers create --fingerprint-os, matching the closed-beta API that already accepted both OS overrides.

parseFingerprintOS accepts macos and linux (string-cast to the SDK type) and rejects anything else with an updated error. The --fingerprint-os help text lists both values. TestBrowsersCreate_WithFingerprintOS exercises both accepted values and the new rejection message.

Reviewed by Cursor Bugbot for commit 213fb1e. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@JonnyShuali
JonnyShuali force-pushed the hypeship/fingerprint-os-linux branch from 43cae5c to 213fb1e Compare November 19, 2026 18:40
@JonnyShuali
JonnyShuali marked this pull request as ready for review November 20, 2026 18:08
@JonnyShuali

Copy link
Copy Markdown
Author

closing: main already accepts linux for --fingerprint-os since the sdk bump in #322, so this has no diff left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant