Repository navigation
Accept linux for --fingerprint-os - #323
Closed
JonnyShuali wants to merge 1 commit into
Closed
JonnyShuali wants to merge 1 commit into
JonnyShuali wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
JonnyShuali
force-pushed
the
hypeship/fingerprint-os-linux
branch
from
November 19, 2026 18:40
43cae5c to
213fb1e
Compare
JonnyShuali
marked this pull request as ready for review
November 20, 2026 18:08
Author
|
closing: main already accepts linux for --fingerprint-os since the sdk bump in #322, so this has no diff left. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernel browsers create --fingerprint-osonly acceptedmacosand rejectedlinuxclient-side. The API accepts both values for organizations with the closed beta enabled, so the CLI now does too.parseFingerprintOSacceptsmacosandlinux; the error message lists both.linuxconstant forBrowserFingerprintOs, but the type is a string, so the validated value is converted directly.Testing
go build ./...,go vet ./...,go test ./...pass.TestBrowsersCreate_WithFingerprintOSnow covers both accepted values and asserts the rejection message.kernel browsers create --stealth --fingerprint-os linux -o jsonreturns"fingerprint":{"os":"linux"}, and an unsupported value fails withInvalid --fingerprint-os value: windows (must be macos or linux).🤖 Generated with Claude Code
Note
Low Risk
Small CLI validation and test updates for an existing closed-beta flag; no auth or infrastructure changes.
Overview
The CLI now treats
linuxas a valid value forkernel browsers create --fingerprint-os, matching the closed-beta API that already accepted both OS overrides.parseFingerprintOSacceptsmacosandlinux(string-cast to the SDK type) and rejects anything else with an updated error. The--fingerprint-oshelp text lists both values.TestBrowsersCreate_WithFingerprintOSexercises both accepted values and the new rejection message.Reviewed by Cursor Bugbot for commit 213fb1e. Bugbot is set up for automated code reviews on this repo. Configure here.