Skip to content

Document 1Password connect links - #770

Merged
bmsaadat merged 3 commits into
mainfrom
bmsaadat/kernel-2808-1password-connect-links
Nov 19, 2026
Merged

bmsaadat merged 3 commits into
mainfrom
bmsaadat/kernel-2808-1password-connect-links

Conversation

@bmsaadat

@bmsaadat bmsaadat commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Documents action.connect_url from kernel/kernel#5612 on the 1Password page:

  • New "Offer a connect link" section: what the connect link does on iOS/Android vs elsewhere, showing it as the main option with action.url as "I already have 1Password", opening it as a page load or with the system URL handler, and that either link settles the authorization, both expire together, and recovery links have none.
  • The pending_authorization row and step 1 of the KERNEL-managed checklist mention the connect link.

Merge after kernel/kernel#5612 is deployed to production.

🤖 Generated with Claude Code


Note

Low Risk
Documentation-only updates to the 1Password integration guide; no runtime or API code changes.

Overview
Documents action.connect_url on the 1Password brokered-approval page so integrators can support users with and without 1Password installed.

The KERNEL-managed OAuth checklist, sequence diagram, code samples, and pending_authorization status row now tell apps to present connect_url alongside action.url. Expiration text notes both links refresh together on upsert.

A new "Offer a connect link" section explains mobile app vs browser/sign-up behavior, pairing action.url as an "already have 1Password" option, opening connect_url via the system URL handler on phones, and constraints (no prefetch, first approval wins, partner preview). Recovery is clarified: recovery OAuth actions expose url only, not connect_url.

Reviewed by Cursor Bugbot for commit 0c5eeee. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mintlify

mintlify Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Kernel 🟢 Ready View Preview Nov 19, 2026, 11:06 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

Also fixes the expiry and web view details against 1Password's spec.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@masnwilliams masnwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accurate, and it matches the API behavior and 1Password's connect-link guidance. one fix before merge, plus a few optional suggestions.

fix: checklist step 1 says to offer the connect link "to users who don't have 1Password yet", but the new section says to present it for everyone, with action.url as the "I already have 1Password" option. a reader who stops at the checklist will build the wrong UI. suggestion inline.

optional, take or leave:

  • the TypeScript and Python samples (// Present account.action.url…) and the sequence diagram (present oauth url) still mention only the one link. naming both would help people who copy the samples.
  • expiry is now covered in two places: "the authorization url expires after a short time…" above, and "both links expire at the same time" in the new section. you could fold the second into the first.
  • "a recovery link has no connect_url" might read more naturally in the recovery section. it currently says to present its url "as you did when connecting", which now means two links.
  • 1Password still labels connect links as partner preview ("details may change"). a short note would set expectations, since the comparison table calls this path generally available.
  • nit: "unlike action.url, it also works for…" can drop the "also".

Comment thread vaults/1password.mdx Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bmsaadat

Copy link
Copy Markdown
Contributor Author

Thanks Mason! Took all of them in 0c5eeee: your checklist wording, both links named in the samples and diagram, expiry folded into the paragraph above, the recovery note moved to the recovery section, a partner preview note, and dropped the "also".

@masnwilliams masnwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, all addressed. lgtm.

@bmsaadat
bmsaadat merged commit d70ad45 into main Nov 19, 2026
3 checks passed
@bmsaadat
bmsaadat deleted the bmsaadat/kernel-2808-1password-connect-links branch November 19, 2026 23:13

This branch was successfully deployed

1 active deployment
staging — 0c5eeee9 Deployed Nov 19, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants