Repository navigation
[Client] Answer a server request with an unknown method or invalid params with an error - #762
Open
andre-schade wants to merge 1 commit into
Conversation
…rams with an error Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andre-schade
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 20, 2026 05:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
MessageFactorycannot build a server request (unknown method, or params that don't match the request class),Client\Protocol::processMessage()only logged a warning, so the server waited for an answer until its timeout. JSON-RPC requires an error response, and the server side already sends one.The client now answers with -32601 for an unknown method and -32602 for invalid params, using the request id the exception carries. Other unreadable messages, e.g. a malformed response, are still only logged.
🤖 Generated with Claude Code