Skip to content

DCR RegistrationHandler accepts {"redirect_uris": null} and returns 201 Created for authorization_code clients #3885

Open

Description

@0718lol

Initial Checks

Release line

2.x (current stable)

Description

POST /register (mcp.server.auth.handlers.register.RegistrationHandler.handle) properly rejects requests where redirect_uris is omitted (400 invalid_client_metadata) or empty (redirect_uris: [], 400 invalid_client_metadata), but accepts {"redirect_uris": null} and returns 201 Created, minting a client_id and client_secret and persisting a client with redirect_uris=None via provider.register_client(...).

Root cause

  1. OAuthClientMetadata.redirect_uris (src/mcp/shared/auth.py:118) is typed list[AnyUrl] | None = Field(..., min_length=1) so non-redirect flows (such as pre-registered jwt-bearer clients) can construct OAuthClientMetadata(redirect_uris=None).
  2. Because None satisfies the union and bypasses min_length=1, an explicit JSON "redirect_uris": null passes OAuthClientMetadata.model_validate_json(body).
  3. RegistrationHandler.handle() (src/mcp/server/auth/handlers/register.py) requires "authorization_code" in grant_types and "code" in response_types (and explicitly refuses jwt-bearer), yet never checks if not client_metadata.redirect_uris:.

Impact

  • Violates RFC 7591 §2 ("Clients using flows with redirection MUST register their redirection URI values").
  • Mirrors the exact invariant already enforced for private_key_jwt in RegistrationHandler.handle() (lines 53–64): mints credentials and stores a client record whose every /authorize request will fail OAuthClientInformationFull.validate_redirect_uri() with InvalidRedirectUriError.

Suggested fix

Keep OAuthClientMetadata.redirect_uris: list[AnyUrl] | None unchanged (so non-redirect client models continue working), and add an explicit check in RegistrationHandler.handle() after the grant_types/response_types checks:

if not client_metadata.redirect_uris:
    return PydanticJSONResponse(
        content=RegistrationErrorResponse(
            error="invalid_client_metadata",
            error_description="redirect_uris is required for authorization_code grant",
        ),
        status_code=400,
    )

I have a minimal fix + regression test verified locally (pytest, ruff, pyright) and would be happy to submit a PR if this is confirmed.

Example Code

import asyncio
import httpx2
from pydantic import AnyHttpUrl
from starlette.applications import Starlette

from mcp.server.auth.provider import OAuthAuthorizationServerProvider
from mcp.server.auth.routes import create_auth_routes
from mcp.server.auth.settings import ClientRegistrationOptions
from mcp.shared.auth import OAuthClientInformationFull


class DummyProvider(OAuthAuthorizationServerProvider):
    def __init__(self):
        self.clients: dict[str, OAuthClientInformationFull] = {}

    async def get_client(self, client_id: str) -> OAuthClientInformationFull | None:
        return self.clients.get(client_id)

    async def register_client(self, client_info: OAuthClientInformationFull) -> None:
        self.clients[client_info.client_id] = client_info


async def main() -> None:
    provider = DummyProvider()
    routes = create_auth_routes(
        provider=provider,
        issuer_url=AnyHttpUrl("https://auth.example.com"),
        client_registration_options=ClientRegistrationOptions(enabled=True),
    )
    app = Starlette(routes=routes)
    transport = httpx2.ASGITransport(app=app)
    async with httpx2.AsyncClient(transport=transport, base_url="https://auth.example.com") as client:
        for label, payload in [
            ("missing", {"client_name": "c"}),
            ("empty", {"redirect_uris": [], "client_name": "c"}),
            ("null", {"redirect_uris": None, "client_name": "c"}),
        ]:
            resp = await client.post("/register", json=payload)
            print(label, resp.status_code, resp.json())
    print("registered clients:", len(provider.clients))


asyncio.run(main())
# Actual output:
# missing 400 {'error': 'invalid_client_metadata', 'error_description': 'redirect_uris: Field required'}
# empty 400 {'error': 'invalid_client_metadata', 'error_description': 'redirect_uris: List should have at least 1 item after validation, not 0'}
# null 201 {'response_types': ['code'], 'client_name': 'c', 'token_endpoint_auth_method': 'client_secret_post', 'grant_types': ['authorization_code', 'refresh_token'], 'application_type': 'native', 'client_id': '...', 'client_secret': '...', 'client_id_issued_at': ..., 'client_secret_expires_at': 0}
# registered clients: 1

Python & MCP Python SDK

Python 3.14.8, macOS
modelcontextprotocol/python-sdk main @ 77001c96 (2.3.1.dev20+77001c96)

AI disclosure: AI assistance was used to help investigate and draft this issue; the reproduction and observed output were verified locally.

Activity

  1. added
    bugSomething isn't working
    v1Affects the v1.x maintenance line
    v2Affects the v2 line (2.x on main)
    on Nov 21, 2026
  2. ayushmnnit commented on Nov 22, 2026

    @ayushmnnit

    Reproduced on main (77001c9) with your script. null is the only spelling that gets through: [null], and null for grant_types or response_types, all return 400. The stored client then fails both /authorize variants with 400 invalid_request, and the 201 body leaves redirect_uris out entirely.

    Keeping | None on OAuthClientMetadata makes sense, since the client_credentials and identity-assertion extensions build it with redirect_uris=None. I applied your handler check locally: the null case returns 400, nothing is registered, and tests/server/auth, tests/server/mcpserver/auth, tests/interaction/auth, tests/shared/test_auth.py and tests/client/test_auth.py still pass (415 passed, same as main).

    AI disclosure: I used Claude Code to run these checks and write them up. I reviewed the scripts, the results and the conclusions myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingv1Affects the v1.x maintenance linev2Affects the v2 line (2.x on main)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions