Repository navigation
Description
Initial Checks
- I confirm that I'm using the newest release of my line (the latest 2.x, or the latest 1.x if I'm still on v1)
- I confirm that I searched for my issue in https://github.com/modelcontextprotocol/python-sdk/issues before opening this issue
Release line
2.x (current stable)
Description
POST /register (mcp.server.auth.handlers.register.RegistrationHandler.handle) properly rejects requests where redirect_uris is omitted (400 invalid_client_metadata) or empty (redirect_uris: [], 400 invalid_client_metadata), but accepts {"redirect_uris": null} and returns 201 Created, minting a client_id and client_secret and persisting a client with redirect_uris=None via provider.register_client(...).
Root cause
OAuthClientMetadata.redirect_uris(src/mcp/shared/auth.py:118) is typedlist[AnyUrl] | None = Field(..., min_length=1)so non-redirect flows (such as pre-registeredjwt-bearerclients) can constructOAuthClientMetadata(redirect_uris=None).- Because
Nonesatisfies the union and bypassesmin_length=1, an explicit JSON"redirect_uris": nullpassesOAuthClientMetadata.model_validate_json(body). RegistrationHandler.handle()(src/mcp/server/auth/handlers/register.py) requires"authorization_code"ingrant_typesand"code"inresponse_types(and explicitly refusesjwt-bearer), yet never checksif not client_metadata.redirect_uris:.
Impact
- Violates RFC 7591 §2 ("Clients using flows with redirection MUST register their redirection URI values").
- Mirrors the exact invariant already enforced for
private_key_jwtinRegistrationHandler.handle()(lines 53–64): mints credentials and stores a client record whose every/authorizerequest will failOAuthClientInformationFull.validate_redirect_uri()withInvalidRedirectUriError.
Suggested fix
Keep OAuthClientMetadata.redirect_uris: list[AnyUrl] | None unchanged (so non-redirect client models continue working), and add an explicit check in RegistrationHandler.handle() after the grant_types/response_types checks:
if not client_metadata.redirect_uris:
return PydanticJSONResponse(
content=RegistrationErrorResponse(
error="invalid_client_metadata",
error_description="redirect_uris is required for authorization_code grant",
),
status_code=400,
)I have a minimal fix + regression test verified locally (pytest, ruff, pyright) and would be happy to submit a PR if this is confirmed.
Example Code
import asyncio
import httpx2
from pydantic import AnyHttpUrl
from starlette.applications import Starlette
from mcp.server.auth.provider import OAuthAuthorizationServerProvider
from mcp.server.auth.routes import create_auth_routes
from mcp.server.auth.settings import ClientRegistrationOptions
from mcp.shared.auth import OAuthClientInformationFull
class DummyProvider(OAuthAuthorizationServerProvider):
def __init__(self):
self.clients: dict[str, OAuthClientInformationFull] = {}
async def get_client(self, client_id: str) -> OAuthClientInformationFull | None:
return self.clients.get(client_id)
async def register_client(self, client_info: OAuthClientInformationFull) -> None:
self.clients[client_info.client_id] = client_info
async def main() -> None:
provider = DummyProvider()
routes = create_auth_routes(
provider=provider,
issuer_url=AnyHttpUrl("https://auth.example.com"),
client_registration_options=ClientRegistrationOptions(enabled=True),
)
app = Starlette(routes=routes)
transport = httpx2.ASGITransport(app=app)
async with httpx2.AsyncClient(transport=transport, base_url="https://auth.example.com") as client:
for label, payload in [
("missing", {"client_name": "c"}),
("empty", {"redirect_uris": [], "client_name": "c"}),
("null", {"redirect_uris": None, "client_name": "c"}),
]:
resp = await client.post("/register", json=payload)
print(label, resp.status_code, resp.json())
print("registered clients:", len(provider.clients))
asyncio.run(main())
# Actual output:
# missing 400 {'error': 'invalid_client_metadata', 'error_description': 'redirect_uris: Field required'}
# empty 400 {'error': 'invalid_client_metadata', 'error_description': 'redirect_uris: List should have at least 1 item after validation, not 0'}
# null 201 {'response_types': ['code'], 'client_name': 'c', 'token_endpoint_auth_method': 'client_secret_post', 'grant_types': ['authorization_code', 'refresh_token'], 'application_type': 'native', 'client_id': '...', 'client_secret': '...', 'client_id_issued_at': ..., 'client_secret_expires_at': 0}
# registered clients: 1Python & MCP Python SDK
Python 3.14.8, macOS
modelcontextprotocol/python-sdk main @ 77001c96 (2.3.1.dev20+77001c96)
AI disclosure: AI assistance was used to help investigate and draft this issue; the reproduction and observed output were verified locally.
Activity
ayushmnnit commentedon Nov 22, 2026
Reproduced on main (77001c9) with your script.
nullis the only spelling that gets through:[null], andnullforgrant_typesorresponse_types, all return 400. The stored client then fails both/authorizevariants with 400invalid_request, and the 201 body leavesredirect_urisout entirely.Keeping
| NoneonOAuthClientMetadatamakes sense, since the client_credentials and identity-assertion extensions build it withredirect_uris=None. I applied your handler check locally: the null case returns 400, nothing is registered, andtests/server/auth,tests/server/mcpserver/auth,tests/interaction/auth,tests/shared/test_auth.pyandtests/client/test_auth.pystill pass (415 passed, same as main).AI disclosure: I used Claude Code to run these checks and write them up. I reviewed the scripts, the results and the conclusions myself.