Repository navigation
net: validate onread buffers before each read - #67407
fatihguzeldev wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67407 +/- ##
==========================================
- Coverage 90.72% 90.69% -0.04%
==========================================
Files 798 801 +3
Lines 280102 281589 +1487
Branches 53896 54254 +358
==========================================
+ Hits 254135 255385 +1250
- Misses 16252 16351 +99
- Partials 9715 9853 +138
🚀 New features to boost your workflow:
|
|
could someone share what failed in the windows and linux linked icu jobs? i can see both failures on github, but i don’t have access to the jenkins logs. |
This comment was marked as outdated.
This comment was marked as outdated.
As mentioned in Slack, I've requested
resume-ci
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Error logs from Jenkins show a problem in debug builds: https://ci.nodejs.org/job/node-test-commit-arm-debug/27377/ shows: 15:54:42 ../deps/v8/include/v8-local-handle.h:421:13: error: cannot initialize a parameter of type 'Value *' with an rvalue of type 'v8::Data *'
15:54:42 421 | T::Cast(that.template value<S>());
15:54:42 | ^~~~~~~~~~~~~~~~~~~~~~~~https://ci.nodejs.org/job/node-compile-windows-debug/36163/ shows on https://ci.nodejs.org/job/node-compile-windows-debug/36163/nodes=win-vs2022_clang/ 16:12:53 deps\v8\include\v8-local-handle.h(421,13): error : cannot initialize a parameter of type 'Value *' with an rvalue of type 'v8::Data *' [C:\workspace\node-compile-windows-debug\node\node_base.vcxproj] |
|
Additionally there were changes today that are now causing conflicts. Please rebase the branch in this PR according to the Pull requests documentation. |
an onread buffer can be detached after registration while native code still holds its address. validate the current view before each read and report an error instead of writing into the former backing store. Fixes: nodejs#67397 Signed-off-by: Fatih Güzel <fatihguzeldev@gmail.com>
663b343 to
615c24c
Compare
socket reads can modify an immutable arraybuffer created by transferring
a registered onread buffer, because native code keeps the old address.
fail the read with a socket error when the view is no longer writable.
buffer factories can still supply a replacement and continue reading.
fixes #67397