Skip to content

feat: default query encoding to RFC 3986 (space as %20) - #190

Merged
mromaszewicz merged 1 commit into
oapi-codegen:mainfrom
mromaszewicz:fix/issue-189
Nov 20, 2026
Merged

mromaszewicz merged 1 commit into
oapi-codegen:mainfrom
mromaszewicz:fix/issue-189

Conversation

@mromaszewicz

Copy link
Copy Markdown
Member

Closes: #189

Flips DefaultQueryEncoder from NetURLQueryEncoder to RFC3986QueryEncoder, so generated clients encode a space in query parameters as %20 instead of +.

OpenAPI's default style: form for query parameters is defined by RFC 6570, which encodes a space as %20; + belongs to application/x-www-form-urlencoded, which applies to request bodies. Servers that accept + as a space also accept %20, but strict RFC 3986 servers reject +.

This changes default client behavior and is intended for v1.10.0. To restore the previous encoding:

func init() {
    runtime.DefaultQueryEncoder = runtime.NetURLQueryEncoder{}
}

Path escaping and application/x-www-form-urlencoded request bodies are unaffected.

🤖 Generated with Claude Code

Closes: oapi-codegen#189

Flip `DefaultQueryEncoder` from `NetURLQueryEncoder` to
`RFC3986QueryEncoder`, so generated clients encode a space in query
parameters as `%20` instead of `+`.

OpenAPI's default `style: form` for query parameters is defined by
RFC 6570, which encodes a space as `%20`; `+` belongs to
`application/x-www-form-urlencoded`, which applies to request bodies.
Servers that accept `+` as a space also accept `%20`, but strict
RFC 3986 servers reject `+`.

This changes default client behavior. To restore the previous encoding,
set `runtime.DefaultQueryEncoder = runtime.NetURLQueryEncoder{}` during
program initialization.

Co-Authored-By: Claude <noreply@anthropic.com>
@mromaszewicz
mromaszewicz requested a review from a team as a code owner November 20, 2026 17:33
@mromaszewicz
mromaszewicz merged commit b173098 into oapi-codegen:main Nov 20, 2026
10 checks passed
@mromaszewicz
mromaszewicz deleted the fix/issue-189 branch November 20, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flip DefaultQueryEncoder to RFC3986QueryEncoder (space as %20) in v1.10.0

1 participant