Skip to content

fix(table): use correct caret icon in CollapseColumn for expandable rows - #12728

Closed
redhat-chai-bot wants to merge 1 commit into
patternfly:mainfrom
redhat-chai-bot:fix/table-collapse-column-caret-direction
Closed

redhat-chai-bot wants to merge 1 commit into
patternfly:mainfrom
redhat-chai-bot:fix/table-collapse-column-caret-direction

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Summary

Changes CollapseColumn.tsx to use RhMicronsCaretRightIcon instead of RhMicronsCaretDownIcon, aligning the standard expandable row toggle with the tree-view pattern already used in treeRow.tsx.

Changes

  • CollapseColumn.tsx: Replaced RhMicronsCaretDownIcon import and usage with RhMicronsCaretRightIcon

Before (current)

  • Collapsed: ▼ (caret-down at 0°)
  • Expanded: ▲ (caret-down rotated -180°)

After (this PR)

  • Collapsed: ► (caret-right at 0°)
  • Expanded: ▼ (caret-right rotated 90°)

Companion CSS PR: will be opened in patternfly/patternfly

Closes #12727


AI-generated. Review for accuracy.

@rh-gvincent requested from Slack

Chai persona: Konflux Help

Summary by CodeRabbit

  • Style
    • The collapse column now displays a right-facing caret instead of a downward-facing caret. This changes the icon shown in the table while leaving the available table functionality unchanged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

CollapseColumn now imports and renders the right-caret icon instead of the down-caret icon.

Changes

CollapseColumn caret correction

Layer / File(s) Summary
Update CollapseColumn icon
packages/react-table/src/components/Table/CollapseColumn.tsx
The component imports and renders the right-caret icon in place of the down-caret icon.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: thatblindgeye, rebeccaalpert

Merge Risk: Minimal · up to 99c4d

This swaps the expandable-row caret icon from down to right, which matches the tree-view pattern. The toggle handler and aria-expanded behavior are unchanged. The downward expanded appearance relies on a separately tracked CSS update, and the risk of merging is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title says the fix changes the caret icon used by CollapseColumn for expandable rows. The changeset does exactly that: CollapseColumn.tsx now renders RhMicronsCaretRightIcon instead of RhMicronsCa…
Linked Issues check Passed [#12727] requires replacing RhMicronsCaretDownIcon with RhMicronsCaretRightIcon in packages/react-table/src/components/Table/CollapseColumn.tsx. The whole-PR diff (merge base 5276afd to head 99c4da9…
Out of Scope Changes check Passed The whole-PR diff changes only CollapseColumn.tsx, with +2/-2 lines: the icon import and the icon usage. Both changes directly implement [#12727]. No unrelated files or changes are present. The CSS ch…
Full details: Title check

Explanation

The title says the fix changes the caret icon used by CollapseColumn for expandable rows. The changeset does exactly that: CollapseColumn.tsx now renders RhMicronsCaretRightIcon instead of RhMicronsCaretDownIcon. The title is specific, concise, and names the primary change. The linked objectives (issue #12727) also describe this same icon swap.

Full details: Linked Issues check

Explanation

[#12727] requires replacing RhMicronsCaretDownIcon with RhMicronsCaretRightIcon in packages/react-table/src/components/Table/CollapseColumn.tsx. The whole-PR diff (merge base 5276afd to head 99c4da9) shows the import changed to rh-microns-caret-right-icon and the rendered icon changed to <RhMicronsCaretRightIcon />, inside the same tableToggleIcon wrapper. This is the only coding requirement in the issue, and it is met. The issue's companion CSS work (patternfly/patternfly#8712) is non-coding for this repository and is out of this PR's scope. The issue does not require new automated tests. The diff does not update any snapshot files; if a snapshot in the Table test suite renders this icon, that snapshot may now fail. This was not verified and does not affect the coding requirement.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff changes only CollapseColumn.tsx, with +2/-2 lines: the icon import and the icon usage. Both changes directly implement [#12727]. No unrelated files or changes are present. The CSS change referenced in the PR description and linked issue is not part of this PR, so it does not add out-of-scope changes.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 49c77211-de86-4457-b0cd-0e28e750576d
Commits

Reviewing files that changed from the base of the PR and between 5276afd and 99c4da9.

Files selected for processing: 1

  • packages/react-table/src/components/Table/CollapseColumn.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(table): CollapseColumn uses wrong caret icon for expandable row toggle

1 participant