Repository navigation
Fix premature pending visual state in useTransition docs - #8767
Open
vanibhardwaj05 wants to merge 1 commit into
Open
vanibhardwaj05 wants to merge 1 commit into
vanibhardwaj05 wants to merge 1 commit into
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8710
Problem Description
In
src/content/reference/react/useTransition.md, under the Exposingactionprop from components section:TabButtonby wrapping theactionprop instartTransition, without anyif (isPending)check..pending { color: #777; }in its CSS stylesheet.This created a confusing pedagogical contradiction with the immediately following section (Displaying a pending visual state), which is meant to introduce and explain
isPendingvisual feedback for the first time. Readers observed the pending state in the first demo, rendering the second demonstration redundant.Solution
if (isPending)condition fromsrc/TabButton.jsin the Section 1 Sandpack demo..pending { color: #777; }rule from the Section 1 stylesheet.Verification