Repository navigation
Conversation
app::app_with takes a reader in place of the disk, so serve.rs can build a program from the editor's files. With jsx: true each module also carries the JSX handed to Solid's compiler (emit::view_jsx).
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
The recovering parse reads a missing statement as an empty one without advancing, so parse_block looped until it found a closing brace. A half-typed handler like `onClick={() => { c` made analyze take 8 to 27 seconds.
… http The page shows its header and editor while rxc.wasm downloads, the wasm is stripped (5.5 to 4.8 MB), compiled while streaming and retried on a cut-off download, and Share falls back to the copy command where the Clipboard API is missing.
The playground shows only diagnostics from analyze, so it now passes project: false; analyze per keystroke goes from 0.16 to 0.09 ms once warm.
The Solid view wrote the runtime's notation for three things. An effect is now createEffect(inputs, ($0, $1) => …), a store path write or guess is the store setter with a draft function, and the optimistic setter is setOptimisticX. A function whose body holds another un-collapsed return is collapsed on a later pass, which fixes a for inside the first branch of an if.
src/torx.ts parses Solid 2.0 with the Babel parser Prettier bundles and prints .rx, listing what it cannot read by line. Plain TypeScript beside a component moves to helpers.ts. The compiler then checks the result. tests/torx.check.mts and tests/roundtrip.check.mts cover it.
# Conflicts: # compiler/src/app.rs
brenelz
marked this pull request as ready for review
November 22, 2026 02:35
TypeScript's language service runs in a worker that loads on first use. For .rx it reads the crate's TSX projection through its mappings, as the editor extension does; in the Solid pane it reads the source directly, offers every solid-js export and adds the import on a pick. The playground also moves from Solid 2.0.0-rc.21 to 2.0.3, with @solidjs/vite-plugin 3.0.1.
The Solid view pane links to playground.solidjs.com with the view as main.tsx, mounted with render(), its imported modules as tabs and the compiler's scoped CSS injected. The await and action examples gain users.js and names.js, so what their .d.rx files declare can run. A program that would not run there has no link and says why. deferred x = e now reads as createDeferred in the view, and the converter reads it back.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A browser playground for learning what ReactiveScript compiles to: type
.rxon the left, and the right side shows the same program written with Solid 2.0's own primitives (createSignal,createMemo,createOptimistic,createProjection,action,<Errored>,<Loading>), with the checker's diagnostics underneath. Work in progress; it is not deployed.Compiler change
The language server's WebAssembly build (
src/wasm.rs) already answersanalyzeandpreludeover a hostrx_read, so it can run from memory in a browser. It could not compile, becauseapp::appreads the program from disk. Two small changes make it possible:app::app_withtakes a reader in place of the disk;app::app(the Node-API build andrxc app) calls it withread_diskand behaves as before.serve.rsanswers anapprequest ({entry, overlays, target, moduleName, spa, jsx}) through it. Withjsx: true, each module also carries the JSX handed to Solid's compiler, printed by the newemit::view_jsxoveroxc_codegen(already in the lockfile throughsolidjs-compiler, now a direct dependency).analyzetakesproject: falseto return diagnostics without building the TSX projection, which the playground does not show. Leaving it out keeps the language server's behaviour.The playground also turned up a parser bug that the language server shares: the recovering parse read a missing statement as an empty one without advancing, so
parse_blockspun on an unclosed{at the end of input. A half-typed handler such asonClick={() => { cmadeanalyzetake 8 to 27 seconds.parse_blocknow stops when a pass reads nothing, and the missing}is an ordinary parse error.The napi
wasm32-wasibrowser build was the other candidate, but its WASI has no filesystem, soapp(entry)cannot read sources there.Playground (
site/playground/)A Vite + Solid 2.0.3 app. Each keystroke runs
analyze(withproject: false) for diagnostics andappwithjsx: truefor the program, under 1 ms per keystroke once the compiler is warm. The page renders beforerxc.wasmarrives; the wasm is built with symbols stripped (4.8 MB), compiled while it streams, and retried if the download is cut off. The JSX is formatted with Prettier, thensrc/solidify.tswrites each__rthelper that is a Solid primitive underneath (spec/11 CP-4b,@reactivescript/runtime) as that primitive and strips the mangled names (v$id,w$idbecomeid,setId). This view is a reading aid, not the code that runs. Explain notes name the.rxform behind each line. The program is kept in the URL hash.site/.assetsignoreleavesplayground/out of the static site upload, so deploying reactivescript.dev is unchanged.public/rxc.wasmis built bypnpm wasmand not checked in.Solid to .rx (prototype)
The header's Solid → .rx button turns the page around: Solid 2.0 on the left, the same program as
.rxon the right, fromsrc/torx.ts. It parses the Solid with the Babel parser that Prettier already bundles, so there is no new dependency, and it lists what it cannot read under "Not converted" with the line, rather than guessing. The compiler then checks the.rx, so a Solid program with an await and noErroredboundary getsUNHANDLED_FAILURE.It reads signals, memos, stores and their draft setters, keyed, draft and value-returning projections, optimistic values and stores with their guesses, actions,
createEffect,Show,For,Errored,Loading, and prop patterns. Plain TypeScript beside a component (data,asyncfunctions, anything with statements) moves tohelpers.ts, which the.rximports; JavaScript globals are imported from there too, because.rxhas no ambient names.Three things it found that are not the converter's to fix:
cart.items := items => […], compiles and matches 02 W-6, but the runtime's path writer assigns the function itself (ref/compile/rt-web.ts, thepathofsourceand of the derived store). Converted programs that usesplice, or+=on a path, do not run correctly until that is fixed.store.users.push(x)in a handler compiles with no diagnostic and is lowered to apushon a read of the store, which Solid ignores.triple = { users: … }, is lowered tocreateMemo, where 06 ST-1 sayscreateProjection.Open in Solid Playground
The Solid view pane links to playground.solidjs.com with the view as
main.tsx, mounted withrender(), the program's plain modules as tabs, and the compiler's scoped CSS injected (src/solidplay.ts). All six examples were opened on the live site through the page's own links and their previews read. A program that would not run there (the view still needs the runtime, or it imports a module with no file) has no link, and a tooltip says why.deferred x = enow reads ascreateDeferredin the view, and the converter reads it back.Types on hover, and completion
Both editors answer "what is this" and "what can go here" from TypeScript's language service, in a Web Worker (
src/types.worker.ts) that loads on the first hover or completion. The worker is 7.9 MB, 1.7 MB gzipped: TypeScript, its DOM and ES libraries, and Solid's types. Page load does not change.For
.rxit reads what the editor extension reads, the crate's TSX projection of each module with its mappings (analyze, spec/13 TY-1c), soidreadssource id: number, an attribute shows its documentation, anduser.offers the store's fields. Names every JavaScript module has are left out, because.rxhas none. In the Solid → .rx pane it reads the Solid source directly, offers everysolid-jsexport, and adds the import when one is picked.Verification
cargo check --manifest-path compiler/Cargo.toml --all-targetscargo test --release --manifest-path compiler/Cargo.toml, including the newan_unclosed_block_at_the_end_of_input_stops.analyzeandapp: the slowest step takes 14 ms.site/playground:pnpm wasm,npx tsc -p .,pnpm build, andpnpm testwithpnpm devrunning: 17 Playwright checks (three of them for hover and completion in both editors, one for the Solid Playground link), covering the featuredawaitlowering, Explain notes, stores, a rest prop asomit, keyed and draft projections, live updates,WRITE_TO_NON_SOURCEwith its rule and guide link, every example, the URL hash, a two-module program, and no page errors.pnpm test:torx(23 cases) andpnpm test:roundtrip(18 cases): each example's.rxgoes to the Solid view, back to.rx, and to the view again, which must match; hand-written Solid must convert and compile, or be refused with the expected number of reasons.==rewrite, renames inside string literals, store reads scoped to their declaring block, two-module formatting, the URL after adding a file, and others).Open
wasm32-unknown-unknowntarget (theeditor.ymlworkflow already builds it) and Vite'sbase: "/playground/".solid-jsalone, and a.d.rxfunction with no written return type readsany.Switch/Match,createRenderEffector custom hooks, and the mode is not kept in the URL.createMemo(() => props.x === undefined ? d : props.x)rather thanmerge:mergekeeps an explicitundefined, while 07 §5 applies defaults onundefined.🤖 Generated with Claude Code