Repository navigation
CLI: Update Go SDK to v0.153.0 - #322
Merged
Merged
Conversation
…lt delete needs a retry KERNEL retries the revoke, not the vault deletion, and a retry can end without 1Password's confirmation. A revoking account from a delete is removed, not linked again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 6 total unresolved issues (including 5 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3353180. Configure here.
…ettles Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KERNEL cards take --browser-id alone; Link cards/payment_request items and Shop Pay cards still need --browser-id and --page-url together.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
tasks, reports, report-types, service-accounts, workload-identity issuers,
federation-rules, and authentication-events now print
{items, page, per_page, has_more} so scripts can paginate.
Managed-auth and pool configs treat captcha_solver as optional, so the zero value printed false even when solving was on through legacy stealth.
hiroTamada
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
v0.153.0.Coverage
Kernel CLI SDK v0.153.0 coverage report
Result
Pass.
/tmp/kernel-clinow depends ongithub.com/kernel/kernel-go-sdk v0.153.0, and the cumulative CLI work oncli-coverage-updatecovers the non-skipped SDK/OpenAPI surface introduced since the review base.Review base:
9f5199cefc43acb8b46e5960d628e5f4f2f585a4Branch HEAD reviewed:
f322207plus the uncommitted v0.153.0 dependency bumpWorking-tree changes at completion:
go.mod,go.sumonlyNo fetch, commit, push, or publish action was performed.
Dependency update
github.com/kernel/kernel-go-sdkfrom v0.152.0 on the branch (v0.148.0 at the review base) to v0.153.0.go mod tidy; no unrelated dependency changes were introduced.GONOSUMDB=github.com/kernel/kernel-go-sdk.go.sumcontains the v0.153.0 module andgo.modchecksums, andgo mod verifypasses.replacedirective remains ingo.mod.SDK/OpenAPI inventory and coverage
Operations and methods
x-cli-skip: trueoperations: 11/projectsaliases of the seven/org/projectsoperations generated by the SDK.The 11 skipped OpenAPI operations are:
Parameters and flags
false--specJSON parsing for cart lines and totals1pw_disconnectoperation constructorAudit artifacts:
/home/runner/work/_temp/cli-scratch/sdk-matrix.md/home/runner/work/_temp/cli-scratch/cli-matrix.md/home/runner/work/_temp/cli-scratch/sdk-command-coverage.md/home/runner/work/_temp/cli-scratch/sdk-added-field-coverage.txt/home/runner/work/_temp/cli-scratch/openapi-semantic-diff.txtCumulative CLI coverage since the review base
The branch adds the 27 commands corresponding to the 27 newly introduced non-skipped operations:
It also covers cumulative parameter and help changes for:
source_ipconditions, new filters, and theexpiredlifecycle stateHelp text review
Affected command descriptions and flag help were checked against the cumulative OpenAPI descriptions and constraints. The CLI now reflects:
--expected-versionNo additional v0.153.0 help change was required: compared with v0.152.0, v0.153.0 only adds
BrowserCostJSON helpers and thepending,provisional, andunavailablestatus constants. It adds no service method, request field, signature change, or request-field documentation change.Pagination UX
All newly added offset-based list commands expose the required UX:
--page, default 1--per-page, default 20, accepted range 1-99per-page + 1to detect another page while staying within the API maximum of 100(page - 1) * per-pageValidation
Completed successfully:
GONOSUMDB=github.com/kernel/kernel-go-sdk go mod verifyGONOSUMDB=github.com/kernel/kernel-go-sdk go test ./...GONOSUMDB=github.com/kernel/kernel-go-sdk go vet ./...GONOSUMDB=github.com/kernel/kernel-go-sdk go build ./cmd/kernelgit diff --checkfor both the working diff and the full diff from the review baseBrowserCostJSON-helper/constant compile-and-decode checkReal API smoke tests
Read-only smoke tests succeeded for:
cost.status = "pending", exercising the v0.153.0BrowserCostdecoding path against the real API.--status expiredThe available credential was an API key. The service-account and workload-identity list commands reached the real endpoints and received the documented rejection: API keys cannot read or manage workload identity resources. No live mutating operation was performed.
Sanitized smoke log:
/home/runner/work/_temp/cli-scratch/smoke-results.txtFull diff review
Full diff from
9f5199cefc43acb8b46e5960d628e5f4f2f585a4:The changed files are limited to the SDK dependency, command implementations, help/output updates, and tests associated with the v0.149.0-v0.153.0 coverage work. Follow-up commits on the branch correct or clarify the same vault/payment coverage. No unrelated source change, temporary debug code, local module replacement, generated binary, or credential was found in the repository diff.
Validation
Note
Medium Risk
Touches authentication (API keys, policies, service accounts), payment/vault flows, and broad flag semantics across browser commands; mistakes could misconfigure egress, credentials, or authorization in production automation.
Overview
Bumps kernel-go-sdk to v0.153.0 and adds CLI coverage for the new API surface:
tasks,reports,report-types, andservice-accounts(paginated list UX with--page/--per-page), wired fromroot.go.API keys gain service-account-linked creation (with required project + policy), stricter JSON policy parsing including
source_ipCIDR conditions, optional policy replacement on update, richer list filters (created-by, principal type,expiredstatus), and principal/policy detail in tables.Browser-related commands (
browsers,browser-pools,auth connections) introduce--captcha-solver, mark--stealthas deprecated compatibility, adjust default proxy semantics when CAPTCHA solving is on, and block conflicting stealth/captcha flag combinations via shared helpers inbrowser_proxy.go.auth contextnow shows effective policy statements and workload-identity metadata for federated credentials.Vaults updates include KERNEL-card authorize with
--browser-idonly, 1Password dual connect/action links and1pw_disconnect,--include-deletedon item events, AgentCard cart-line spec help, and expanded delete/long-help text for payment and revocation behavior. Linux is added as a--fingerprint-osoption alongside macOS.Reviewed by Cursor Bugbot for commit 9f44929. Bugbot is set up for automated code reviews on this repo. Configure here.